AEP comments 13-19

[mcsiple]

13_pop_vs_yield

• [x] I cleaned up the example (deleted K1Plus and fmax)
• [x] I added yaxs=”I” for the three curve version of the plot
• [x] Check z vector is in range.

14_plot_yield_curve

• [x] I cleaned up the example (deleted K1Plus and fmax)
• [x] Check z vector is in range.
• [x] You should not enter z and MNPL_in because they are the same – I would solve for MNPL from z and the other parameters using get_mnpl. Look at the base plot which shows that MNPL=0.5 is not the MNPL for z=2.39
• [x] The description for MNPL is incomplete (but I would drop it anyway).
• [x] I would not pass z twice as the case now. Why not include it lh.params where it belongs
• [x] To get this to work I had to have nages and PlusGroupAge. This is a problem and you should only have nages OR PlusGroupAge in the code

17_plot_proj

• [x] I see you are still passing K1plus and InitDepl
• [x] I ran

  
  x <- plot_proj(
  high = high.simple,
  med = med.simple,
  low = low.simple,
  years.plot = 50,
  ylims = c(0, 2*parms$K1plus), InitDepl = initdepl,
  K1plus = parms$K1plus, spaghetti=5
  )

x

and it crashed. Looks like `spaghetti`  isn’t working.

**18_multiplot_proj**
- [x] There were some glitches with the example
- [ ]`plotyears` needs to be defined in the example (now fixed it as 50)
- [x] Running with “spaghetti=5” worked but produced weird results

**19_graddar**
- [ ] Quite a few warnings when I run the example

[mcsiple]

13: Fixed with 8caca529 . Still need to add range for z checks 14: I have broken the code at some point and need to come back to it I think. Yuck!! commits 8f30edc7 thru f0bc83eb

[mcsiple]

14: TheMNPL and z values that go into this equation in the app go in the following flow: 1) the user specifying an MNPL (we agreed that this was more straightforward than the user entering z), 2) user-specified MNPL is used to calculate z 3) z is then used in this function. So only in the example is there an input that comes Since the MNPL and z used here will always be linked in the app, it makes sense for them to both be inputs. I will add a check to make sure that if there is a Shiny session running, both z and MNPL_in can be specified (time saver), otherwise only z should be entered. Need to fix upstream stuff.

[mcsiple]

Fixed so that it checks whether z is between -0.5 and 6 with commit 91b22aaa Need to return to this later!

[mcsiple]

17

• Regarding putting in both K1plus and InitDepl, they both come from the same place during Shiny app calculations. Technically in the projections() function, InitDepl is defined by the user and K1plus is calculated from the initdepl and the initial population size. I know this isn't ideal so I'll try to come up with a solution.
• Example works fine now; I don't know what was wrong but prob just a simple mistake I made not originally include nages in parms in the example. commit 0d60c194

18

• Fixed example and changed plotyears to be consistent throughout example. I think spaghetti plot is no longer weird? (e27c6cc3)

19

• Not sure what errors are happening with ggradar; I may need to investigate further. Works fine in tests.