AEP comments: 27 and app - Githubissues

mcsiple / mmrefpoints

A package for simulating marine mammal abundance and calculating reference points.

Other

3 stars 5 forks source link

AEP comments: 27 and app #39

Closed mcsiple closed 3 years ago

mcsiple commented 3 years ago

27_rebuild_by_x

[x] Add checks on parameters (e.g. init.deplw.w)
[x] Clarify that goal is number of whales
[x] Probability should be a fraction not a percentage
[x] The example seems to fail (i.e. no recovery possible)
[x] You should not pass fmax AND lambdamax. I think it will work without fmax but best check (and it depends on all my other edits)

The app Simple

[x] Why not start the app at 50% and a range of bycatch / bycatch rate that allows the low case to recovery – right now the results are a little depressing

PBR

[x] You can enter a Rmax < 1 and a Nmin < 0!
[x] “to help compute the abundance estimates “

Model description

[x] “E” on “The number of reproducing..” should be bold italics
[x] Like history types (x=ap+1) not (x=ap+3)??
[x] Life history table for “pinnipeds” the x-axis label “Parameter value” hits the x-axis values
[x] There are still some “Punt et al.(unpublished)” – is this now published?

mcsiple commented 3 years ago

27

Cleaned up and removed fmax from inputs. The example does recover! At E = 0.03. Checks to params added with 5759d90b

App edits

defaults made less depressing for simple and advanced tabs, commit f458ac82
fixed param inputs for PBR to error message when Rmax too high or Nmin too low (160a5129 )
"to help compute" issue fixed with 93920470 .

Model description (all fixed w commits 699eb46d and 6d86eff5)

fixed to boldsymbol{E} in all docs
oops yes should be a_p + 1 because it's agemat+2
Punt et al. (unpublished) is now Punt et al. (2018); it was the paper with Moreno et al.