search

mcspring / googletest

Automatically exported from code.google.com/p/googletest
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

Compiler warning in gtest-printers.cc #350

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
I tried upgrading the version of gtest that Native Client uses from r267 to 
r526 and got the following warning on ARM, which makes the build fail because 
we are using "-Werror":

/home/mseaborn/devel/nacl-trunk/src/native_client/toolchain/linux_arm-trusted/ar
m-2009q3/bin/arm-none-linux-gnueabi-g++ -Werror -O2 -fdiagnostics-show-option 
-I/home/mseaborn/devel/nacl-trunk/src/native_client/toolchain/linux_arm-trusted/
arm-2009q3/arm-none-linux-gnueabi/libc/usr/include -march=armv6 -Wl,-T 
-Wl,/home/mseaborn/devel/nacl-trunk/src/native_client/toolchain/linux_arm-truste
d/ld_script_arm_trusted -o 
scons-out/dbg-linux-arm/obj/src/third_party_mod/gtest/src/gtest-all.o -c 
-std=c++98 -Wall -Wextra -Wno-long-long -Wsign-compare -fvisibility=hidden 
-Werror -march=armv6 -O0 -g -DNACL_WINDOWS=0 -DNACL_OSX=0 -DNACL_LINUX=1 
-D_BSD_SOURCE=1 -D_POSIX_C_SOURCE=199506 -D_XOPEN_SOURCE=600 -D_GNU_SOURCE=1 
-D_LARGEFILE64_SOURCE=1 -D__STDC_LIMIT_MACROS=1 -D__STDC_FORMAT_MACROS=1 
-DNACL_STANDALONE=1 -DNACL_BLOCK_SHIFT=5 -DNACL_BLOCK_SIZE=32 
-DNACL_BUILD_ARCH=arm -DNACL_BUILD_SUBARCH=32 -DNACL_TARGET_ARCH=arm 
-DNACL_TARGET_SUBARCH=32 -D_DEBUG -I/home/mseaborn/devel/nacl-trunk/src 
-I/home/mseaborn/devel/nacl-trunk/src/testing/gtest/include 
-I/home/mseaborn/devel/nacl-trunk/src/testing/gtest 
/home/mseaborn/devel/nacl-trunk/src/testing/gtest/src/gtest-all.cc
cc1plus: warnings being treated as errors
In file included from 
/home/mseaborn/devel/nacl-trunk/src/testing/gtest/src/gtest-all.cc:46:
/home/mseaborn/devel/nacl-trunk/src/testing/gtest/src/gtest-printers.cc: In 
function 'void testing::internal::PrintWideCharsAsStringTo(const wchar_t*, 
size_t, std::ostream*)':
/home/mseaborn/devel/nacl-trunk/src/testing/gtest/src/gtest-printers.cc:294: 
error: comparison of unsigned expression >= 0 is always true [-Wtype-limits]

Original issue reported on code.google.com by mseaborn@chromium.org on 30 Dec 2010 at 8:57

GoogleCodeExporter commented 9 years ago 
This was introduced by r525.

Original comment by mseaborn@chromium.org on 30 Dec 2010 at 9:05

GoogleCodeExporter commented 9 years ago

Original comment by w...@google.com on 4 Jan 2011 at 8:39