mctekk / zohocrm

Wrapper for interact with Zoho CRM API for php
MIT License
49 stars 55 forks source link

deleteRecords supports passing idList - but how to report records deleted? #33

Closed Cloudineer closed 7 years ago

Cloudineer commented 7 years ago

You can pass multiple record Ids to deleteRecords, as the param idList (the same as my pull request #29 for getRecordById). I am happy to submit a pull request for this change. My question for MCTekK and other contributors is how to return the list of deleted records. Currently Response.php L215 uses preg_match to extract a single recordId as $this->recordId, but this does not allow for multiple records deleted.

As I see it the options are:

I'll make a pull request at the end of the week, based on any comments posted here.

Cloudineer commented 7 years ago

Been busy, this slipped off the radar. I will submit a pull request using bullet 2 above. This has less impact for backward compatibility. The list can be easily explode'd if required.

Cloudineer commented 7 years ago

This is closed by pull request #34