search

mctools / ncrystal

NCrystal : a library for thermal neutron transport in crystals and other materials
https://mctools.github.io/ncrystal/
Other
38 stars 17 forks source link

gcc12 compilation issues prevent conda deployment #125

Closed tkittel closed 11 months ago

tkittel commented 1 year ago

Unfortunately we did not have gcc 12 in our unit testing (we do now!), so we missed an annoying compilation error that prevents the conda PR tests from all succeeding, and thus the conda packages for release 3.6.0 from being deployed.

I am trying to make a quick workaround and a release 3.6.1 out the door asap, and then we have to revisit this compilation error after a few weeks when there might be time.

tkittel commented 12 months ago

This will be addressed in the upcoming v3.7.0 release. The aligned allocator was rewritten for better portability (and correctness!), and additionally, the SmallVector::clear method needed to be rewritten in a very specific way before gcc12 would stop giving (wrong!) errors.

tkittel commented 11 months ago

Fixed in v3.7.0.