mctools / ncrystal

NCrystal : a library for thermal neutron transport in crystals and other materials
https://mctools.github.io/ncrystal/
Other
38 stars 17 forks source link

Consider a more clean split between Python and non-Python parts of an NCrystal installation. #152

Open tkittel opened 7 months ago

tkittel commented 7 months ago

As seen in #151 such a split would be useful for packaging, and might solve the issue of how to properly install NCrystal into a system-wide environment without resorting to simply doing a pip install (which then adds the NCrystal binaries to the python env and does not have the NCrystal cmake files in the CMAKE_PREFIX_PATH.

Perhaps ncrystal-config would no longer be aware of the --pypath, and be the only script installed irrespective or not of whether NCRYSTAL_ENABLE_PYTHON was set. All other scripts should in any case be defined as proper python entry points rather than exist as actual scripts in the src repo. The pip-install of NCrystal python modules should then support a mode where the library was taken from the core package, rather than being bundled inside the python module directory.