search

mctools / ncrystal

NCrystal : a library for thermal neutron transport in crystals and other materials
https://mctools.github.io/ncrystal/
Other
38 stars 17 forks source link

Explicitly forbid # and $ in cfg-strings #153

Closed tkittel closed 7 months ago

tkittel commented 7 months ago

# and $ seems obvious candidates for exclusion from cfg-strings, since they might be troublesome in various contexts (e.g. bash scripts, or .ncmat data where parts of a cfg-string after the # would be considered comments). This was noted in #144 .

tkittel commented 7 months ago

Relevant place in code: https://github.com/mctools/ncrystal/blob/master/ncrystal_core/include/NCrystal/internal/NCCfgTypes.hh#L43

tkittel commented 7 months ago

Implemented in v3.8.0, closing!