mctools / ncrystal

NCrystal : a library for thermal neutron transport in crystals and other materials
https://mctools.github.io/ncrystal/
Other
38 stars 17 forks source link

Spurious failure in some dos-expansion related unit tests #167

Open tkittel opened 4 months ago

tkittel commented 4 months ago

In the ncrystaldev repo (and thus in the simple-build-dgcode CI) we have several unit tests that fail on osx due to tiny floating-point variations between macos and linux (or, clang vs. gcc?). Although it would be great to figure out the cause of these discrepancies, it is likely that this is simply a feature of floating point irreproducibilities, and we should at least make the unit tests more robust so that they do not flag issues that are irrelevant.

For reference, here is how I am currently avoiding these tests on osx:

           if [ "$RUNNER_OS" == "macOS" ]; then
             export tmp="${tmp}"',!sb_nclongextratests_testdosplot'
             export tmp="${tmp}"',!sb_nclongextratests_testplots2'
             export tmp="${tmp}"',!sb_nclongtests_testloadvdos'
             export tmp="${tmp}"',!sb_nclongtests_testrange'
             export tmp="${tmp}"',!sb_nclongtests_vdosloaddbg'
           fi                                                                                                                                                                                          
           sb -t --testexcerpts=100 --testfilter="{$tmp}" 
tkittel commented 4 months ago

Once fixed, we should reenable the tests in simple-build-dgcode's condatest_essncrystaldev.yml