search

mctools / simplebuild-dgcode

dgcode: the Geant4-based simulation framework of the ESS Detector Group. Provided as simple-build-system bundles.
https://mctools.github.io/simplebuild-dgcode/
Other
2 stars 1 forks source link

Several suggested changes to the documentation #23

Closed MilanKlausz closed 6 months ago

tkittel commented 6 months ago

Hi @MilanKlausz

Thanks a lot for the many fixes, this is great! I have responded with a comment to a few of them, could you address these and then update the PR?

tkittel commented 6 months ago

I was a bit confused why your test would fails with a failure message related to some changes in tk_volatile. But then I realised that this PR is going into tk_volatile and not main!

It should got into main, not my private volatile branch! :-)

tkittel commented 6 months ago

@MilanKlausz I have changed the base, but I think you need to push a new commit (can be an empty commit) to the PR branch, in order to trigger the tests to launch again.

tkittel commented 6 months ago

Concerning the weird These utilities assume that the in scans.rst, this incomplete sentence can actually just be removed I think. I think that what I was going to write there, eventually ended up in the "Important notice" box just below it.

MilanKlausz commented 6 months ago

I believe that all the issues are addressed now.