mcu-debug / rtos-views

RTOS views for microcontrollers
MIT License
24 stars 11 forks source link

Allow combinations of ColTypeEnum #1

Open PhilippHaefele opened 1 year ago

PhilippHaefele commented 1 year ago

As preparation for adding link support (to show memory in mcu memory view), we should add the possibility to set multiple ColTypeEnum values at once and also pass multiple values to the DisplayRowItem.value entries (current code only allows one value in DisplayRowItem).

Currently i see following combinations that then could be implemented in getHTMLCommon:

One approach would be to use different / more specific (and optional like value right now) value entries in DisplayRowItem.

Also not sure if we should then better add enum entries that reflect the allowed/implemented combinations?

What do you think about this in general and the approaches from above?

haneefdm commented 1 year ago

Hmmm. I am not getting emails on new Issues. On the memory view repo, I do sometimes and don't sometimes.

Btw, the ColTypeEnum is already an enum that are masks. You can set more than one (sanely) item. It can be colTypePercentage + colTypeLink already. Since I don't have any links, I have not tested it.

Now that I have a memory view, I intend to create a link for stack and see what the gaps are for changing/enhancing the type definitions.

Also not sure if we should then better add enum entries that reflect the allowed/implemented combinations?

Yup