Rework IRP locking - Githubissues

tormodvolden commented 12 months ago

This is on top of my PR https://github.com/mcuee/libusb-win32/pull/36

Note this has only been minimally tested with xusb.exe so far.

driver: Rework cancel and timeout handling in call_usbd_ex This is based on the "text book" (the MS documentation referenced in the commit message) The original code is using the same event for 2 different purposes, which I think is wrong.
driver: Allow synchronous return from lower driver in get_current_frame Also just based on code review and MS documentation.

I am curious whether this (especially the call_usbd_ex patch) can help for issue https://github.com/libusb/libusb/issues/1255

mcuee commented 12 months ago

@dontech

Please help to look at this PR when you got the time. Thanks.

dontech commented 12 months ago

Really impressive patch @tormodvolden.

Quick question: most of the patches are cosmetic, but the last 2 can have deeper impact. Was there an actual problem here, or are these also cosmetic? Was there failing test cases?

Thanks,

/pedro

dontech commented 12 months ago

Ah, OK i answered my own question. The failing test case was here: https://github.com/libusb/libusb/issues/1255

Yes, my original fix was just not good enough :-(

Thanks again @tormodvolden for fixing this.

Approved.

mcuee / libusb-win32

Rework IRP locking #38