Changes to authentication, settings and utils - Githubissues

mcueto / djangorestframework-auth0

Library to simply use Auth0 token authentication in DRF within djangorestframework-jwt

MIT License

91 stars 19 forks source link

Changes to authentication, settings and utils #18

Closed snake575 closed 7 years ago

snake575 commented 7 years ago

Hi! I refactored and moved a lot of things but the functionality is the same:

Settings module:

In the settings module there was an error on AUTH0_CLIENT_SECRET, when CLIENT_SECRET_BASE64_ENCODEDis Falseit's not necessary to do replace("_", "/").replace("-", "+")
Added new USERNAME_FIELDto settings, this allows to specify which scope field in the token is to be used as a username
Refactored JWT_PAYLOAD_GET_USERNAME_HANDLER as an import string to avoid circular dependencies

Settings module:

Removed unnecessary functions: authenticate and get_jwt_value
Refactored Auth0JSONWebTokenAuthentication, now it inherits from django.contrib.auth.backends.RemoteUserBackend, it' has a very similar functionality with the original implementation

Utils module:

Removed unnecessary functions: jwt_decode_handler
get_jwt_value now uses JWT's JSONWebTokenAuthentication implementation
Changed get_group to group's', as token payload contains a group array instead of a single group
Same for get_role to get_role's'

Thanks for stating this project by the way!

Greetings from Antofagasta :grin:

mcueto commented 7 years ago

@Snake575 manually tested, merged to master and uploaded updated version to pypi ;) in the following weeks i'll be adding some tests(continuous integration) to this package.

Nice weekend