search

mcustiel / phiremock-common

Common classes for Phiremock
GNU General Public License v3.0
3 stars 4 forks source link

Upgrade laminas/laminas-diactoros #16

Closed s0lus closed 6 months ago

s0lus commented 9 months ago

For support php 8.3

s0lus commented 9 months ago

@mcustiel, hey! Looks like Scrutinizer doesn't support php 8.3. Do you mind if I switch to github actions?

s0lus commented 8 months ago

@mcustiel ping

s0lus commented 8 months ago

@mcustiel ping

mcustiel commented 8 months ago

Hello @s0lus Sorry for the delay, I was away from computers during the last month. As soon as I have enough time I will have a look at your PR. In advance: thank you very much for taking time to do changes and improvements.

mcustiel commented 8 months ago

@mcustiel, hey! Looks like Scrutinizer doesn't support php 8.3. Do you mind if I switch to github actions?

Hello @s0lus, for me that would not be a problem as long as it runs all the nice quality checks that scrutinizer runs. Thank you for the proposal :)

s0lus commented 7 months ago

@mcustiel Hey! I think it's ready for review, but there is a problem with coverage badge and code quality score from Scrutinizer.

I didn't find any alternative for code quality score badge, but for code coverage we can use codecov. I don't have permission to set up codecov in your project, so it's better that you to do that.

Also, github actions not displaying on your repo, but I think after merge it will. Anyway to prove that this works here pipeline from my fork https://github.com/s0lus/phiremock-common/actions

s0lus commented 7 months ago

@mcustiel friendly ping :)

mcustiel commented 6 months ago

Thank you very much for your help @s0lus