Cygwin make fails due to missing _O_BINARY error in xxHash

mcveanlab / mccortex

De novo genome assembly and multisample variant calling

https://github.com/mcveanlab/mccortex/wiki

MIT License

113 stars 25 forks source link

Cygwin make fails due to missing _O_BINARY error in xxHash #61

Closed ffranr closed 7 years ago

ffranr commented 7 years ago

This issue effects mccortex because of it's dependency on xxHash (https://github.com/Cyan4973/xxHash/tree/88c6ee1e4db6155dbe7047fed793cb8406b56086).

Original issue in xxHash repo (opened 16th of March 2017): https://github.com/Cyan4973/xxHash/issues/100

noporpoise commented 7 years ago

Thanks for pointing this issue out. I've removed xxHash from our dependencies in 01d43275ec7bff92f74360a41d8bc84928d62368. Will merge into master after the tests run.