mcveanlab / mccortex

De novo genome assembly and multisample variant calling
https://github.com/mcveanlab/mccortex/wiki
MIT License
113 stars 25 forks source link

Compilations fails: "city.c:405:10: fatal error: 'citycrc.h' file not found" #76

Open jonchang opened 5 years ago

jonchang commented 5 years ago

city.c conditionally includes citycrc.h if the macro __SSE_4_2__ is defined, which it is on all processors sold in the last decade. However, this file is not checked into git and the make all step fails.

Steps to reproduce:

Expected behavior:

No errors.

Actual behavior:

cc -Wall -Wextra -O3 -march=native -c city.c -o city.o
city.c:405:10: fatal error: 'citycrc.h' file not found
#include "citycrc.h"
         ^~~~~~~~~~~
1 error generated.
make: *** [city.o] Error 1
jonchang commented 5 years ago

I'm trying to get this software into Homebrew. While our binary builds use -march=core2 and will thus be unaffected, builds from source always use -march=native and thus break compilation.

noporpoise commented 5 years ago

I've added the missing file on the master branch -- could you try now?

noporpoise commented 5 years ago

I've added the missing citycrc.h file and created a new release -- please let me know if this resolves your issues.