search

mcvine / acc

Accelerated mcvine engine
0 stars 1 forks source link

add method `applyTransformation` and use it in "compiled" instrument script #108

Closed yxqd closed 1 year ago

yxqd commented 1 year ago

In current implementation, the coordinate transformation from one component to the next is done with method abs2rel, which is confusing. Should make an alias method applyTransformation and use that.

yxqd commented 1 year ago

@granrothge I added this test to check the coordinate transformation. It is certainly not comprehensive but I wonder if you have some test cases in your mind I can quickly implement.

yxqd commented 1 year ago

@ckendrick @granrothge I added an alias of abs2res named applyTransformation and used it in run_script

yxqd commented 1 year ago

@granrothge I am going to merge this. Will add more tests if need to.