search

mcvine / acc

Accelerated mcvine engine
0 stars 1 forks source link

Add type hints to code #27

Open mtbc opened 2 years ago

mtbc commented 2 years ago

It would make sense to add at least some level of type hinting to our code, especially starting while the project is young. CI could then use Mypy.

mtbc commented 2 years ago

I am holding off for now because numpy 1.21 offers NDArray and, from my MCViNE environment, if I conda install numpy=1.21 then I get numpy 1.20.3.

mtbc commented 2 years ago

Possibly also worth waiting for https://github.com/numpy/numpy/issues/16544 before putting effort in here.