search

mcvine / acc

Accelerated mcvine engine
0 stars 1 forks source link

Sample "isotropic box" #78

Closed yxqd closed 2 years ago

yxqd commented 2 years ago

This is first attempt to implement a sample component. This is not a generic component that supports various shapes and kernels, but a simple one that has a box shape and an isotropic kernel.

yxqd commented 2 years ago

@mtbc For testing the new component, I refactored the instrument_factory module in tests/components/optics/. The majority of your code for instrument_factory was moved to the mcvine.acc.test.instrument_factory module, but some code specific for testing guides are left in tests/components/optics/. Please check.

yxqd commented 2 years ago

@mtbc I also moved the test_helper module to mcvine.acc.test.compare_acc_nonacc and made it a bit more customizable

yxqd commented 2 years ago

@mtbc Could you please check the revisions to mcvine.acc.test and tests in tests/components/optics? This PR seems ready for merge. Thanks.