Closes issue #174 and issue #189: Remove 2nd definition from 'aggrega…

[dillerm]

…te of organizations' and create new money and money-related terms with defintions and labels.

[hoganwr]

Some issues I see: No term editor annotation on new classes No contributor annotations on new classes

OBO suggests (I think strongly but not required): example of usage annotation, editor preferred term annotation

I do not know if they want editor preferred term different from rdfs:label

[dillerm]

They don't make any mention of an rdfs:label, just an editor preferred term, which they define as "a unique, unambiguous label for the term in American English" (Source). I'm currently working on adding an example of usage, term editor, and contributor annotation to each new class.

[hoganwr]

Sorry for not being clear. ROBOT makes sure everything's got an rdfs:label. That is a must, even if it's not explicitly written down somewhere.

My only point was does the rdfs:label have to be different from the editor preferred? If not, then add editor preferred term to all classes. You could instead make them more wordy to be more precise.

On Wed, Aug 24, 2022 at 5:31 PM Matthew Diller @.***> wrote:

They don't make any mention of an rdfs:label, just an editor preferred term, which they define as "a unique, unambiguous label for the term in American English" (Source https://github.com/jamesaoverton/obo-tutorial/blob/master/docs/ontology-development.md). I'm currently working on adding an example of usage, term editor, and contributor annotation to each new class.

— Reply to this email directly, view it on GitHub https://github.com/ufbmi/OMRSE/pull/190#issuecomment-1226402880, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJR55V6MNJSZSEQQBAQPKTV22IEFANCNFSM57NEZFGA . You are receiving this because your review was requested.Message ID: @.***>

[dillerm]

That's what I mean: they don't specify what the annotation has to be (e.g., rdfs:label or IAO:editor-preferred-term) and they use "label" and "editor preferred term" interchangeably. I'm inclined to say that rdfs:label suffices for this requirement.

[jamesaoverton]

rdfs:label is important because it's what is used for display in programs like Protege and many more. ROBOT report complains if it is not present.

'editor preferred term' is not required, but is used by many projects such as IAO and OBI. It can be the same as rdfs:label, and it often is. The advantage to having both is that downstream users may want/need to change the rdfs:label to adapt terms to their use case, while the 'editor preferred term' stays the same as the (upstream) source ontology. For example, in a tree view where the ancestry is visible and space is at a premium, a shorter rdfs:label can be more clear than a verbose label.

[hoganwr]

James, thank you so much for the clarification. That info is extremely helpful.

On Wed, Aug 24, 2022 at 6:13 PM James A. Overton @.***> wrote:

rdfs:label is important because it's what is use for display in programs like Protege and many more. ROBOT report complains if it is not present.

'editor preferred label' is not required, but is used by many projects such as IAO and OBI. It can be the same as rdfs:label, and it often is. The advantage to having both is that downstream users may want/need to change the rdfs:label to adapt terms to their use case, while the 'editor preferred label' stays the same as the (upstream) source ontology. For example, in a tree view where the ancestry is visible and space is at a premium, a shorter rdfs:label can be more clear than a verbose label.

— Reply to this email directly, view it on GitHub https://github.com/ufbmi/OMRSE/pull/190#issuecomment-1226487849, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJR55U3KY73XDHRTHUUJS3V22NB7ANCNFSM57NEZFGA . You are receiving this because your review was requested.Message ID: @.***>

[dillerm]

@hoganwr and I reviewed this together and determined it was ready to merge.