search

mcwdsi / OMRSE

The Ontology for Modeling and Representation of Social Entities
Creative Commons Attribution 4.0 International
14 stars 7 forks source link

Closes issue #194, issue #196, issue #202, issue #206, and issue #207… #208

Closed dillerm closed 1 year ago

dillerm commented 1 year ago

…: Fixes definition of 'role in human social processes'; deprecates 'residential function'; creates class 'birth attendant role'; changes label of 'insurance company' to 'insurance organization'; and adds classs 'religious gathering', 'hospital bed capacity data item', 'proportion of population in an elementary occupation', 'Medicaid policy holder role', 'US state Medicaid agency', 'insurance company', and 'private insurance policy holder role'.

hoganwr commented 1 year ago

Done. Plus fixed several minor ROBOT report errors.

On Tue, May 16, 2023 at 12:07 AM Nico Matentzoglu @.***> wrote:

@.**** commented on this pull request.

In src/ontology/Makefile https://github.com/ufbmi/OMRSE/pull/208#discussion_r1194582726:

@@ -1,7 +1,7 @@

----------------------------------------

Makefile for omrse

Generated using ontology-development-kit

-# ODK Version: v1.4 +# ODK Version: v1.3.1

Be careful! You are using an old ODK, run "docker pull obolibrary/odkfull" and then update_repo again

— Reply to this email directly, view it on GitHub https://github.com/ufbmi/OMRSE/pull/208#pullrequestreview-1427678361, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJR55WYJOXTFSC6UKW45H3XGL4QLANCNFSM6AAAAAAYC6E3UI . You are receiving this because your review was requested.Message ID: @.***>

hoganwr commented 1 year ago

Ok, now I also finished my review. Just committed two minor changes. If this looks good to you, go ahead and merge.

On Tue, May 16, 2023 at 7:18 AM Bill Hogan @.***> wrote:

Done. Plus fixed several minor ROBOT report errors.

On Tue, May 16, 2023 at 12:07 AM Nico Matentzoglu < @.***> wrote:

@.**** commented on this pull request.

In src/ontology/Makefile https://github.com/ufbmi/OMRSE/pull/208#discussion_r1194582726:

@@ -1,7 +1,7 @@

----------------------------------------

Makefile for omrse

Generated using ontology-development-kit

-# ODK Version: v1.4 +# ODK Version: v1.3.1

Be careful! You are using an old ODK, run "docker pull obolibrary/odkfull" and then update_repo again

— Reply to this email directly, view it on GitHub https://github.com/ufbmi/OMRSE/pull/208#pullrequestreview-1427678361, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJR55WYJOXTFSC6UKW45H3XGL4QLANCNFSM6AAAAAAYC6E3UI . You are receiving this because your review was requested.Message ID: @.***>

dillerm commented 1 year ago

Looks good to me!