search

mcwdsi / OMRSE

The Ontology for Modeling and Representation of Social Entities
Creative Commons Attribution 4.0 International
14 stars 7 forks source link

Fixed qc errors caused by obsolete class equivalent class assertions … #225

Closed dillerm closed 6 months ago

dillerm commented 6 months ago

…and subclassof assertions that referenced anonymous resources, and re-loaded d-acts import to fix issue #188.

dillerm commented 6 months ago

@matentzn , I've fixed the errors caused by the obsolete classes that had equivalent class axioms and subclass axioms that referenced an anonymous resource. I left the other deprecated_class_reference errors alone since they are caused by obsolete classes that have not been moved to the 'ObsoleteClass' hierarchy. I believe we've discussed this in the past, but our rationale for not touching those obsolete classes is that any data annotated with them could become inaccessible. One question we have about this is whether these violations would end up breaking the build process for releases.

matentzn commented 6 months ago

Great! seems QC is happy with it! Are you sure you want to update the release files like this? Maybe better to only update the edit file first, then the import in a separate PR, and then do a proper release? Like this, some release files will be different than others..

dillerm commented 6 months ago

@matentzn , good point. I will close this pull request and open a new one.