search

mcwdsi / dron

10 stars 1 forks source link

updated Makefile to remove assertions of ChEBI classes being subclass… #20

Closed hoganwr closed 1 year ago

hoganwr commented 1 year ago

… of OBI's processed material that is currently an artifact of the build process

hoganwr commented 1 year ago

Fixes #18

jamesaoverton commented 5 months ago

This fix didn't work for me. In grep -v "SubClassOf.*CHEBI_.*/OBI_0000047" the / character failed to match, so the subClassOf axioms were not being removed. I deleted the / in my local copy and then it worked as expected.

I'll be making a PR that eliminates the need for this, so there's no need to change it now.

hoganwr commented 5 months ago

James thanks for the fix.

The copy paste from the markdown pages for sure doesn’t work.

Bill

On Fri, Apr 19, 2024 at 10:07 AM James A. Overton @.***> wrote:

This fix didn't work for me. In grep -v "SubClassOf.CHEBI_./OBI_0000047" the / character failed to match, so the subClassOf axioms were not being removed. I deleted the / in my local copy and then it worked as expected.

I'll be making a PR that eliminates the need for this, so there's no need to change it now.

— Reply to this email directly, view it on GitHub https://github.com/mcwdsi/dron/pull/20#issuecomment-2066773054, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJR55V72JHM7Q3RLXPKRH3Y6EXJXAVCNFSM6AAAAAAZFHEX4CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRWG43TGMBVGQ . You are receiving this because you modified the open/close state.Message ID: @.***>