search

mcwdsi / dron

9 stars 1 forks source link

Use templates to build DrOn #25

Closed jamesaoverton closed 1 month ago

jamesaoverton commented 2 months ago

This PR (1) shows how to convert DrOn components to templates (which should be a one-time task), and (2) converts templates to DrOn component OWL files.

Please test it by checking out this branch and following these steps:

cd src/ontology
sh run.sh make all_components -B
sh run.sh make prepare_release -B COMP=false MIR=false IMP=false

Then download the v2024-03-03 release and run diff to compare the dron.owl files. The diff should show only three kinds of difference:

  1. the versionIRI and versionInfo are different, as they should be
  2. many "ChEBI X subclass of OBI 'processed material'" axioms are dropped -- As discussed on our last call, the new code is behaving properly, and these axioms should not have been in the last release.
  3. I'm adding three duplicate rdfs:labels: 'anti-hypertensive function', 'anti-hypertensive function', 'analgesic function' -- these are already in dron-edit.owl with an @en language tag. I will fix this in future updates.

It would have been nice to eliminate differences 2 and 3, but after a few attempts I decided that it's too much effort for the benefit.

Please confirm that the build steps work and you only see these differences. Then I'll have a few refinements before we merge this. Thanks!

hoganwr commented 2 months ago

Also, I ran it again on a second machine (which admittedly is fairly similar to the first one: OSX, 32GB or more of RAM, and I think even Apple chips), and obtained the same result.