mcwdsi / dron

9 stars 1 forks source link

Obsolete and replace terms 2 #28

Open jamesaoverton opened 3 weeks ago

jamesaoverton commented 3 weeks ago
jamesaoverton commented 3 weeks ago

@hoganwr When you have time, please start reviewing this PR. I suggest working through the commits in order.

My next step is to obsolete about 8000 duplicate DrOn terms.

jamesaoverton commented 3 weeks ago

After obsoleting the ~8000 DrOn terms with duplicate label+RxCUI pairs, I still have about 16 DrOn terms with duplicate labels but differing RxCUIs (some obsolete). I also have 668 duplicate RxCUIs in DrOn. Most seem to be obsolete or remapped by RxNorm. We'll discuss those on the next call.

hoganwr commented 3 weeks ago

I have completed a build in commit 3af928b9362296eaf4c916716bc6fd437629eda7 and it looks good. I have the build going on the subsequent commit.

hoganwr commented 2 weeks ago

I'm up to commit 4e8a376ce1822de1b45ed37518b17d08a7db1688

The new ChEBIs, which are referred to via term_replaced_by on obsoleted DrOn terms, are showing up at the top level. But I think that's easily fixed by updating the ChEBI import, and perhaps the subsequent commits accomplish that.

I'm going to go ahead and move to the next commit.

jamesaoverton commented 2 weeks ago

The new ChEBIs, which are referred to via term_replaced_by on obsoleted DrOn terms, are showing up at the top level. But I think that's easily fixed by updating the ChEBI import, and perhaps the subsequent commits accomplish that.

Ok, we'll be sure that's cleaned up before we commit.