search

mcyc / mufasa

MUlti-component Fitter for Astrophysical Spectral Applications
GNU General Public License v3.0
0 stars 2 forks source link

Could benefit from adding IndexError #30

Open mcyc opened 10 months ago

mcyc commented 10 months ago

https://github.com/mcyc/mufasa/blob/9325a72a1cc7952a3629c439e7a8501d776ccfc9/mufasa/moment_guess.py#L185

This line leads to SpectralCube.py raising an index error downstream. Adding the IndexError to the exception may be useful if the problem is associated with multicore fails.

Screen Shot 2024-01-02 at 4 06 57 PM
mcyc commented 10 months ago

The index error encountered above indeed arose from a bug with pyspeckit. An issue (https://github.com/pyspeckit/pyspeckit/issues/405) has been opened for this bug. Unfortunately, this bug affects both single and multi-core usage, and adding the IndexError to the exception will not bypass the problem before the bug is solved.

mcyc commented 10 months ago

The bug downstream with pyspeckit has been fixed in commit https://github.com/pyspeckit/pyspeckit/commit/2432eb03f0686754052672f94431b97f64edf4f7.

An IndexError exception message that indicates the pyspeckit version needs to be up to date to address this issue would be beneficial.