mczachurski / wallpapper

:computer: Console application for creating dynamic wallpapers for macOS Mojave and newer
MIT License
3.31k stars 137 forks source link

Having multiple sequence kinds breaks functionality #55

Open saleebm opened 2 years ago

saleebm commented 2 years ago

Hi, thanks for this wonderful open source library!

I noticed that the example in the README under solar didn't work so I investigated it by using the built-in metadata extractor to find the difference between a working Solar dynamic image and the one generated by the example format. I noticed that for the Dynamic Wallpaper to work on MacOS 11.6, I needed to remove isForDark and isForLight to get the image to work properly with Solar.

Here is a broken one's metadata:

Reading HEIC file: '/REDACTED.../blackNwhiteAnimals.heic'...---------------------------------------------------
Metadata key: tiff:Orientation
    value: 1
---------------------------------------------------
Metadata key: apple_desktop:h24
[APPERANCE]
    image index: 5, dark
    image index: 0, light
[TIME]
    image index: 0, time: 0.8333333333333334
    image index: 1, time: 0.0
    image index: 2, time: 0.16666666666666666
    image index: 3, time: 0.3333333333333333
    image index: 4, time: 0.5
    image index: 5, time: 0.6666666666666666
---------------------------------------------------
Metadata key: iio:hasXMP
    value: True

Working one:

Reading HEIC file: '/REDACTED/Earth%20View.heic'...---------------------------------------------------
Metadata key: apple_desktop:solar
[SOLAR]
    image index: 0, azimuth: 279.66, altitude: 27.95
    image index: 1, azimuth: 4.16, altitude: -31.05
    image index: 2, azimuth: 27.03, altitude: -26.1
    image index: 3, azimuth: 45.83, altitude: -15.23
    image index: 4, azimuth: 60.58, altitude: 0.05
    image index: 5, azimuth: 72.8, altitude: 16.31
    image index: 6, azimuth: 84.31, altitude: 34.16
    image index: 7, azimuth: 97.87, altitude: 52.38
    image index: 8, azimuth: 122.59, altitude: 69.59
    image index: 9, azimuth: 196.03, altitude: 77.09
    image index: 10, azimuth: 248.53, altitude: 64.0
    image index: 11, azimuth: 267.27, altitude: 46.15
    image index: 12, azimuth: 291.18, altitude: 10.41
    image index: 13, azimuth: 304.07, altitude: -5.95
    image index: 14, azimuth: 320.06, altitude: -19.51
    image index: 15, azimuth: 340.41, altitude: -28.63
---------------------------------------------------
Metadata key: tiff:Orientation
    value: 1
---------------------------------------------------
Metadata key: iio:hasXMP
    value: True

Maybe I am missing something though, but this helped me get Solar images working.