mczachurski / wallpapper

:computer: Console application for creating dynamic wallpapers for macOS Mojave and newer
MIT License
3.31k stars 137 forks source link

fixed minutes not being utilized in time info calculation #68

Closed compufox closed 1 year ago

NanoExplorer commented 1 year ago

Have you had luck using this? I applied this patch to my version of wallpapper and while the metadata in the output file as viewed with wallpapper -e has higher resolution, it seems the OS is still only changing the image hourly. I wonder if this is just a limitation of the dynamic wallpaper implementation in the OS?

compufox commented 1 year ago

while I have not used this patch in wallpapper, I'm using this same logic in a personal project and the HEIC files it spits out do change on the minute and not just the hour.

i'll build a version with the patch and see if I can replicate your issue

compufox commented 1 year ago

i built the tool and it works fine. i had to fiddle with the timezone for the images, but thats it. maybe its something to do with that?

here's the json file i used:

[
    {
        "isPrimary": true,
        "fileName": "1.png",
        "time": "2023-02-15T17:16:00-0500"
    },
    {
        "fileName": "2.png",
        "time": "2023-02-15T17:17:00-0500"
    },
    {
        "fileName": "3.png",
        "time": "2023-02-15T17:18:00-0500"
    }
]

it could also depend on what version of macOS you're on, maybe? i'm on 13.2.1 for what it's worth.