search

md-5 / SpecialSource

Automatic generator and renamer of jar obfuscation mappings.
Other
202 stars 51 forks source link

Filedates bugged in jars produced by gradle #40

Closed Sedridor closed 6 years ago

Sedridor commented 8 years ago

All the jar files created by gradle build have their contained files and folders set to filedate 1980-01-01 0:00 modified and the created/accessed timestamps are completely missing (set to null?). This makes it difficult to check when certain mods were released, as the downloaded jar's timestamp is set to the time of download, not the time of creation.

After closer inspection I've found the cause of the bug. In net/md_5/specialsource/JarRemapper.java at line 212 there is entry.setTime(0);, this line needs to be removed to fix the issue.

md-5 commented 8 years ago

It's not actually a bug, it's for reproducible builds.

AbrarSyed commented 8 years ago

I definitely dont think reproduceable builds is the domain of SpecialSource.. if needed, another tool or something can be written just to strip out the timestamps..