md-5 / SpecialSource

Automatic generator and renamer of jar obfuscation mappings.
Other
202 stars 51 forks source link

Look up field/method access for all remappings #61

Closed SquidDev closed 3 years ago

SquidDev commented 3 years ago

Sorry for the rather weird implementation - I wasn't sure how much you cared about backwards compatibility of the API in the actual Java code, so I've tried to preserve it as much as possible. Happy to clean it up if that's not an issue.

This changes the remapper to always call findAccess when remapping a name, rather than just on visitFieldInsn/visitMethodInsn instructions. This means that method handles are remapped using the correct access flag, and so references to private methods are not remapped.

Fixes #60

md-5 commented 3 years ago

ac2c4663cbcf430ecd2ad0878771f58e053b8f51 Thank you

SquidDev commented 3 years ago

Thanks for merging!