search

md-systems / pathauto

DEPRECATED: Pathauto moved back to drupal.org, use the official repository.
https://www.drupal.org/project/pathauto
29 stars 34 forks source link

Fixing bug with punctuation settings not getting loaded/used #86

Closed singularo closed 8 years ago

singularo commented 9 years ago

Found that this is an issue when we needed to allow the period '.' in urls, and it was still being stripped out

Berdir commented 9 years ago

Strange. That duplicated nesting doesn't really make sense. There's also one additional test fail (one is expected currently, but you have two).

Maybe the bug is actually in the form that is saving those values?

singularo commented 9 years ago

If so, that would be the standard pathauto form. And that could be it the exported config from the install profile looks like:

$ cat pathauto.settings.yml punctuation: punctuationdouble_quotes: 0 punctuationquotes: 0 punctuationbacktick: 0 punctuationcomma: 0 punctuationperiod: 2 punctuationhyphen: 1

Which indeed, seems incorrect. So yeah, I'd say the actual bug is in the form code. I'll take a look in the next couple of days.

Berdir commented 8 years ago

I've fixed this as part of the big config entity refactoring, thanks for originally noticing and reporting this.