Fix redirect form ajax callback

md-systems / redirect

DEPRECATED: Redirect moved back to drupal.org, use the official repository.

https://www.drupal.org/project/redirect

21 stars 29 forks source link

Fix redirect form ajax callback #68

Closed jhedstrom closed 8 years ago

jhedstrom commented 8 years ago

The ajax callback was making the form unusable by always setting focus back on the path input area.

This is a temporary fix for #67 that makes the form usable again. I'm not exactly sure what the intention of the ajax callback is at the moment.

jhedstrom commented 8 years ago

This is now properly working. I think the ajax callback should probably be using the form state somehow, but since an actual form error is never set, perhaps not?

Berdir commented 8 years ago

Confirmed, didn't see that before. Also the link title in the widget seems new. Maybe the options changed or something?

Berdir commented 8 years ago

Merged, but this doesn't actually fix it? I now get a warning after actually filling out the form, no matter what value. It always says it's a valid URL. An then the focus problem is back.

Berdir commented 8 years ago

Ah, you just get that when using a / at the end, forgot that it's not needed here ;)