search

md-systems / redirect

DEPRECATED: Redirect moved back to drupal.org, use the official repository.
https://www.drupal.org/project/redirect
21 stars 29 forks source link

[#66] Remove count query on fix 404 form #84

Open juampynr opened 8 years ago

juampynr commented 8 years ago

Fixes https://github.com/md-systems/redirect/issues/66

juampynr commented 8 years ago

@Berdir is there anything missing in this pull request that I should work on?

Berdir commented 8 years ago

That's not really fixing much. There's a lot broken on that page. Sorting for example.

The main reason for that is that the code still assumes that the path is stored in the message directly. For reasons that I don't really agree with, this was changed shortly before release and the path is now in the variables.

We could switch everything that's looking at message to look at location instead.

Or we could push https://github.com/md-systems/redirect/pull/47 forward, which is trying to solve this completely by having our own table to track 404's that support things like dealing with multiple languages and avoiding a dependency on the dblog module. Would be great to push that forward, has a review from me that needs to be addressed.

juampynr commented 8 years ago

I like the idea of #47, but from my experience dblog has been always replaced by syslog in production environments, which makes this feature useles. What if we simply remove this feature for good?

Berdir commented 8 years ago

That's the one of the reasons for doing #47. We completely remove our dependency on dblog.module and you can enable or disable it separately from that.

juampynr commented 8 years ago

Ok then! On Feb 12, 2016 12:50 PM, "Sascha Grossenbacher" notifications@github.com wrote:

That's the one of the reasons for doing #47 https://github.com/md-systems/redirect/pull/47. We completely remove our dependency on dblog.module and you can enable or disable it separately from that.

— Reply to this email directly or view it on GitHub https://github.com/md-systems/redirect/pull/84#issuecomment-183293084.