search

md-systems / redirect

DEPRECATED: Redirect moved back to drupal.org, use the official repository.
https://www.drupal.org/project/redirect
21 stars 29 forks source link

[#51] Add permission to administer Redirect settings #85

Open juampynr opened 8 years ago

juampynr commented 8 years ago

For https://github.com/md-systems/redirect/issues/51.

Based on https://github.com/md-systems/redirect/pull/65.

juampynr commented 8 years ago

@Berdir is there anything missing in this pull request that I should work on?

Berdir commented 8 years ago

Usually, an administer permission can do everything. That's a pretty common pattern. I'm not sure I like changing that.

What if we turn it around and introduce something like a "manage redirects" permission and update the titles/descriptions so that it's clear that administer allows access to the settings and redirects, while the second permission only allows to manage redirects?

juampynr commented 8 years ago

That makes sense to me. Updating pull request now.