search

mdabros / SharpLearning

Machine learning for C# .Net
MIT License
384 stars 85 forks source link

SharpLearning.XGBoost.dll is not compatible with .net core #136

Open festith opened 4 years ago

festith commented 4 years ago

Hi, SharpLearning.XGBoost.dll is not compatible with .net core due to PicNet.XGBoost (0.2.1) dependency. Checked on 0.31.8 version. And Core 2.1 version Do you plan to fix it?

mdabros commented 4 years ago

Hi @festith, Currently PicNet.XGBoost is the handling the interop with XGBoost, so the quickest route to having this fixed is probably to open an issue in XGBoost.Net and have them update the package to be compatible with .Net Core 2.1.

Longer term I might add my own wrapper for handling the interop with XGBoost. That way I can easilier make changes and add support for new features.

Best regards Mads

mdabros commented 4 years ago

@festith Seems a PR has already been made: https://github.com/PicNet/XGBoost.Net/pull/28 If it is merged I will update the package for Sharplearning, and that should provide support for .net core 2.1.

fbraun4358 commented 3 years ago

@mdabros PicNet/XGBoost really appears to be abandonware - no updates since 2018 or any signs of live for getting up to date with netstandard2.0, or .Net Core 3.1+

mdabros commented 3 years ago

@fbraun4358 I agree on that observation. Might be time for a new C# wrapper for XGBoost. I have been thinking of making one, but I have not had the time yet sadly.

coffeebenzene commented 3 years ago

Hello, it took quite awhile, but it seems that my commit has just been merged. Although, it still stands that there's no real updates since 2018

mdabros commented 3 years ago

@coffeebenzene Sadly they did not publish a new nuget package it seems: https://www.nuget.org/packages/PicNet.XGBoost/

If I can get them to publish one, I will upgrade SharpLearning.