search

mdaines / grammophone

A tool for analyzing and transforming context-free grammars.
https://mdaines.github.io/grammophone
MIT License
200 stars 23 forks source link

Highlight locally ambiguous nodes in the automaton view. #37

Closed modulovalue closed 7 months ago

modulovalue commented 8 months ago

I think it would be helpful if the "Automaton" views would give nodes a different background color (e.g., red) if any of the cells in their table view are locally ambiguous (that is, if there is an R/R or S/R conflict).

To be more concrete:

Screenshot 2023-11-06 at 13 16 46

Since State 6 is inadequate, it would be helpful if State 6 could have a red background in the automaton view, too.

Screenshot 2023-11-06 at 13 24 31
mdaines commented 7 months ago

Seems like a good idea. I'll take a closer look in a week or two.

mdaines commented 7 months ago

I'm working on this in PR #38.

mdaines commented 7 months ago

I just deployed the changes in that PR.