mdanka
commented
5 years ago Hi! Thanks for all the comments everywhere :) I'm quite busy right now, but I will read through these and have a think hopefully later this week!
On Mon, 13 May 2019 at 17:52, Christophe Noël notifications@github.com wrote:
Hello!
I've been working on separate stuff for a while, now ready to come back to your lib :)
So based on what I understand here: https://github.com/mdanka/momo-chords/blob/b22e162431a2c9bcb5d04b940d92157124863adb/src/chordSymbolParser.ts#L179 it seems that, by design, it is not possible to parse the chord C69, quite common in jazz/bossa, because intervals always come before addeds. That makes C96 parsable, but not C69. That also explains why I had trouble getting A7+, which can only be written A+7, when the former is a pretty common form as well.
Possible solution would be to change the parsing algorithm so the order of the different chords parts does not matter? Could be something like:
- parse the root note, the quality, then the bass note, and isolate the rest. That seems to be pretty stable and being opinionated here should not remove any flexibility from the user.
- from here the "rest" is a bit more blurry and if I agree that most cases respect the order you have defined, this might not always be the case. So we instead of parsing everything "at once", we could loop on the different regexp, removing the matches as we find them. For ex: get the intervals take what's left. Get the added, take what's left. Etc. until we have no more characters in the input string?
What do you think?
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/mdanka/momo-chords/issues/29?email_source=notifications&email_token=AB5SG37O3C3GXUQMM5TCQM3PVGFCBA5CNFSM4HMRFOKKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4GTO4THQ, or mute the thread https://github.com/notifications/unsubscribe-auth/AB5SG32VEGFVVHMDNKOOB4LPVGFCBANCNFSM4HMRFOKA .
no-chris
Hello!
I've been working on separate stuff for a while, now ready to come back to your lib :)
So based on what I understand here: https://github.com/mdanka/momo-chords/blob/b22e162431a2c9bcb5d04b940d92157124863adb/src/chordSymbolParser.ts#L179 it seems that, by design, it is not possible to parse the chord
C69, quite common in jazz/bossa, becauseintervalsalways come beforeaddeds. That makesC96parsable, but notC69. That also explains why I had trouble gettingA7+, which can only be writtenA+7, when the former is a pretty common form as well.Possible solution would be to change the parsing algorithm so the order of the different chords parts does not matter? Could be something like:
What do you think?