search

mdasberg / ng-apimock

Node plugin that provides the ability to use scenario based api mocking: for local development for protractor testing
MIT License
99 stars 26 forks source link

Improvement: Add baseUrl at run configuration #43

Closed victorsoliveira closed 6 years ago

victorsoliveira commented 6 years ago

I'm trying to use ngapimock lib, but, geneated protractor-mock.js use "browser.baseUrl" fixed info and i'm trying to use with my ionic project , but i need the mock server up at different port of my ionic project.

So, if i make a improve at run configuration adding a baseUrl info we can use that at protractor-mock.js, if was null, use browser.baseUrl.

Can i make this improve and send a PR for u ?

Thanks!

wswebcreation commented 6 years ago

Hi @victorsoliveira

That would be awesome. @mdasberg Will you also pick that up in the refactor?

mdasberg commented 6 years ago

@victorsoliveira of course, please do, I will implement it in the rewrite as well

victorsoliveira commented 6 years ago

@mdasberg I'm doing now! Thanks!

victorsoliveira commented 6 years ago

@mdasberg PR #44!

victorsoliveira commented 6 years ago

@wswebcreation The PR #44 was merged! @mdasberg waiting for next release! ;-)

mdasberg commented 6 years ago

@victorsoliveira v1.4.5 has been released