mdasberg / ng-apimock

Node plugin that provides the ability to use scenario based api mocking: for local development for protractor testing
MIT License
99 stars 26 forks source link

Feature/request body matching #55

Closed ainsleybc closed 5 years ago

ainsleybc commented 6 years ago

A non-breaking change to allow mocks to be matched on the request body (resolves #21).

If the mock is configured to match on the request body, this will take precedence over other mocks where the body property is not defined.

Notes:

let me know if I should do anything else!

lalmanzar commented 6 years ago

Hopefully this get incorporated soon. It's a must have feature.

wswebcreation commented 6 years ago

Hi @ainsleybc

Thanks for this PR, looks nice! @mdasberg is currently busy with a refactor of this module. I don't know when this will be merged due to his time.

mdasberg commented 5 years ago

@ainsleybc thanks for the pr. This functionality will be added to the new version too.

DHFW commented 5 years ago

Hi @mdasberg, can you please release a new version soon? It is working for me, using a forked version. And, the good thing with this you can support REST and GraphQL with this solution (because GraphQL is using the body, not the URL). That is a big selling point for your fantastic module!

mdasberg commented 5 years ago

@DHFW I will have a look at it tomorrow.

I have been working on a new version. It has been split up and has some extra features like presets and body and header matching.

DHFW commented 5 years ago

@mdasberg Do you have an estimate on when you can release the new version? We have to use a workaround in our team to use the ng-api mock server now...

mdasberg commented 5 years ago

@DHFW I have just released v1.4.7.

DHFW commented 5 years ago

@mdasberg Thank you! Without any rewrites in our code we have it working now!