search

mdavidsaver / cashark

Wireshark dissector plugin for EPICS protocols
Other
24 stars 11 forks source link

feat: add pva.count field #13

Closed thomasives closed 1 year ago

thomasives commented 1 year ago

I don't know much about wireshark plugins so this might be missing something, but it works on my machine :)

mdavidsaver commented 1 year ago

I don't know much about wireshark plugins so this might be missing something,

This is nice simple change to start with.

but it works on my machine :)

The usual extent of my testing (now automated with GHA) is to process the test/ files. Those test/pva-search*.pcapng being particularly relevant. The first thing to look for are Lua exceptions.

What I see in the uploaded test logs looks correct.

mdavidsaver commented 1 year ago

Since my requested change was so small, I went ahead and made it. Thanks for making time for this PR.