search

mdavidsaver / cmake4epics

support for using CMake to find EPICS and build IOCs
Other
6 stars 3 forks source link

The name of the default debug build type is "Debug" #1

Closed mark0n closed 7 years ago

mark0n commented 7 years ago

String comparison in CMake is case sensitive so this needs to be aligned with the conventions or other CMake modules might fail.

See the CMake documentation for a description of the allowed values.

mdavidsaver commented 7 years ago

I find several references, and my own experience, to say that CMAKE_BUILD_TYPE should be treated as case-insensitive. So the proper fix is to use string(TOUPPER ...) prior to the comparisons.

http://lists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20150810/292471.html