Work in progress (w/ API changes) - Githubissues

mdavidsaver / pvxs

PVA protocol client/server library and utilities.

https://mdavidsaver.github.io/pvxs/

Other

19 stars 25 forks source link

Work in progress (w/ API changes) #18

Closed mdavidsaver closed 3 years ago

mdavidsaver commented 3 years ago

As with #11. I'm creating this PR mainly as a venue to mention several in the big set of changes which may cause problems for dependent code.

Incompatible API change

Removal of the methods peerName() and rawCredentials() from the server operation classes. These are superseded by the new credentials() method, which returns a ClientCredentials object which has the peer name and raw credentials Value as well as additional information (user groups).

Behavior change

A number of client methods no longer synchronize with the client worker thread. This synchronization was unnecessary for the library, and was causing deadlocks in the new gateway code. I don't think this will adversely impact other user code. Operation cancellation will still synchronize (by default) so eg. binding local variable references into a callback lambda remains safe. Though if this is inconvenient, look to the new operation builder method syncCancel(false).

AppVeyorBot commented 3 years ago

:x: Build pvxs 1.0.464 failed (commit https://github.com/mdavidsaver/pvxs/commit/c9928f01a5 by @mdavidsaver)

AppVeyorBot commented 3 years ago

:white_check_mark: Build pvxs 1.0.479 completed (commit https://github.com/mdavidsaver/pvxs/commit/55f7a3e62b by @mdavidsaver)

AppVeyorBot commented 3 years ago

:x: Build pvxs 1.0.483 failed (commit https://github.com/mdavidsaver/pvxs/commit/0b63f16b6a by @mdavidsaver)

AppVeyorBot commented 3 years ago

:x: Build pvxs 1.0.490 failed (commit https://github.com/mdavidsaver/pvxs/commit/1fd5b1a796 by @mdavidsaver)

AppVeyorBot commented 3 years ago

:x: Build pvxs 1.0.504 failed (commit https://github.com/mdavidsaver/pvxs/commit/2cb50dfda8 by @mdavidsaver)

AppVeyorBot commented 3 years ago

:white_check_mark: Build pvxs 1.0.540 completed (commit https://github.com/mdavidsaver/pvxs/commit/b4a20519ae by @mdavidsaver)

AppVeyorBot commented 3 years ago

:white_check_mark: Build pvxs 1.0.550 completed (commit https://github.com/mdavidsaver/pvxs/commit/7273f4573c by @mdavidsaver)

AppVeyorBot commented 3 years ago

:white_check_mark: Build pvxs 1.0.557 completed (commit https://github.com/mdavidsaver/pvxs/commit/04c6f7f86a by @mdavidsaver)

AppVeyorBot commented 3 years ago

:white_check_mark: Build pvxs 1.0.566 completed (commit https://github.com/mdavidsaver/pvxs/commit/1331e4c736 by @mdavidsaver)

AppVeyorBot commented 3 years ago

:white_check_mark: Build pvxs 1.0.570 completed (commit https://github.com/mdavidsaver/pvxs/commit/25cf3afe5e by @mdavidsaver)