Use @rpath as install_name prefix on MacOS (fixes #8)

mdavidsaver / setuptools_dso

setuptools extension for building non-Python Dynamic Shared Objects

Other

9 stars 6 forks source link

Use @rpath as install_name prefix on MacOS (fixes #8) #9

Closed mtikekar closed 4 years ago

mtikekar commented 4 years ago

@loader_path prefix requires dependent libraries to be in the same directory or to use install_name_tool to change the name after linking. With this fix, linker's -rpath can be used instead.

mdavidsaver commented 4 years ago

Thank you for opening a PR. Something strange has happened with travis CI though. I'll investigate.

mtikekar commented 4 years ago

I have seen this on another repo as well. It is probably because I am not a regular contributor on this repo. It might be easiest if you make the commit yourself.

mdavidsaver commented 4 years ago

Ok, so just that simple. I guess Mach-O actually isn't as different from ELF as I had first thought.

mdavidsaver commented 4 years ago

I've made an additional change to which -rpath entries are added. Before I upload to pypi.org, can you confirm that this still works for your case?

mtikekar commented 4 years ago

Yes, it works. Thanks!

mdavidsaver commented 4 years ago

Released in 1.6

navytux commented 4 years ago

@mtikekar, @mdavidsaver, thanks - this fixed pygolang build system to finally work on macOS:

https://lab.nexedi.com/nexedi/pygolang/commit/fb662979