mdazfar2 / HelpOps-Hub

Welcome to HelpOps-Hub: your go-to resource for essential DevOps tools and technologies. Simplify your DevOps journey with curated guides, tools, and best practices. Never get stuck again!⚡
https://helpopshub.com
MIT License
40 stars 58 forks source link

Feat: Converted Classes to BEM Naming Convention #646

Closed shreyash3087 closed 4 days ago

shreyash3087 commented 4 days ago

Description:

This PR converts classes to follow BEM naming convention,and fixes a margin issue on the Resources Page.

Issue Mentioned:

Closes #604

Changes Done-

Video:

https://github.com/mdazfar2/HelpOps-Hub/assets/72603662/d2676bce-3ab8-42d5-92bc-51758e727500

Additional Context:

This PR is half of the full convertion work,the next half will be done in next PR

vercel[bot] commented 4 days ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
helpops-hub2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 25, 2024 6:40am
github-actions[bot] commented 4 days ago

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

shreyash3087 commented 4 days ago

@mdazfar2 Someone had changed the margin of resources page by mistake i think so i fixed that as well-

Screenshot (71)

Screenshot (72)

shreyash3087 commented 4 days ago

@mdazfar2 also before merging this PR kindly preview it on vercel first,and see if there's any issue,because it might be possible i might have missed any class by mistake(im a human)

mdazfar2 commented 4 days ago

@mdazfar2 Someone had changed the margin of resources page by mistake i think so i fixed that as well-

Screenshot (71)

Screenshot (72)

Already raised issue for that @shreyash3087

shreyash3087 commented 4 days ago

@mdazfar2 no problem then thats good

mdazfar2 commented 4 days ago

update sync fork @shreyash3087

shreyash3087 commented 4 days ago

@mdazfar2 already did,its showing up to date

mdazfar2 commented 4 days ago

It is not showing up to date you can compare with the current ones: @shreyash3087


image

shreyash3087 commented 4 days ago

@mdazfar2 just the contact page is not updated right? ill fix it,any other page which is not updated??

mdazfar2 commented 4 days ago

@shreyash3087 you already solved this right?


image

shreyash3087 commented 4 days ago

@mdazfar2 the margin issue? yes i did

mdazfar2 commented 4 days ago

@mdazfar2 just the contact page is not updated right? ill fix it,any other page which is not updated??

You solved for resource bugs right?? If it is solved please mention issue #641 as solved @shreyash3087

shreyash3087 commented 4 days ago

alright will mention that and update the contactus page,just give me a minute

mdazfar2 commented 4 days ago

@shreyash3087 check out the dark mode in about page there is color issue in text as well as team

shreyash3087 commented 4 days ago

alright

mdazfar2 commented 4 days ago

@shreyash3087 look at this also


image

mdazfar2 commented 4 days ago

@shreyash3087 There are many bugs in dark mode when we reload in team and contact. I think I should not merge this. Can we close this one? I think there is no need for BEM convention. please don't feel bad :)

shreyash3087 commented 4 days ago

@mdazfar2 thats totally fine =) i wont have to do more work then on other pages,you can close it i think,its just that the codebase has become so large even i dont know which element is having effects form which classes sometimes they have effect from other page classes.