test flow accumulation with new assertions

mdbartos / pysheds

:earth_americas: Simple and fast watershed delineation in python.

GNU General Public License v3.0

708 stars 191 forks source link

test flow accumulation with new assertions #177

Closed itati01 closed 2 years ago

itati01 commented 2 years ago

The pull request contains new assertions for the flow accumulation as discussed in #168 . It also does not rely on external efficiency grids. I was surprised to see that the maximum flow accumulation = outlet cell appears twice in the accumulation arrays. However, this facilitates the testing, especially for Dinf. A deprecation warning of pytest is also removed.

mdbartos commented 2 years ago

Posted a couple quick comments. Could you change these lines? Thx.

itati01 commented 2 years ago

Sure. I have removed some more comments referring to the efficiency grids. Additionally, the grid files are removed.

mdbartos commented 2 years ago

Looks good to me!