mdbartos / pysheds

:earth_americas: Simple and fast watershed delineation in python.
GNU General Public License v3.0
702 stars 188 forks source link

Cannot replicate the example using 'elevation.tiff' #211

Open johnratcliff opened 1 year ago

johnratcliff commented 1 year ago

ElevationExample I am just getting started with pysheds and I am trying to replicate the example that is posted, but I get different results for the flow direction, accumulation, catchment delineation and river network extraction. I have essentially copied and pasted the script into my own Jupyter notebook, so I am confused as to why. I have attached images of the results that I get. The code is the same as the example code on the ReadMe page. If someone can help me out, I would be greatly appreciative.

-John

philippkraft commented 1 year ago

Looks like you forgot to fill pits and depressions and resolve flats. If I leave them out I get the same picture as you.

# Condition DEM
# ----------------------
# Fill pits in DEM
pit_filled_dem = grid.fill_pits(dem)

# Fill depressions in DEM
flooded_dem = grid.fill_depressions(pit_filled_dem)

# Resolve flats in DEM
inflated_dem = grid.resolve_flats(flooded_dem)
mdbartos commented 1 year ago

Thanks @philippkraft!

johnratcliff commented 1 year ago

Okay, thanks! Sounds like that's probably it so I'll give it another try.

John


From: Philipp Kraft @.> Sent: Thursday, February 9, 2023 12:42 PM To: mdbartos/pysheds @.> Cc: Ratcliff, John David @.>; Author @.> Subject: Re: [mdbartos/pysheds] Cannot replicate the example using 'elevation.tiff' (Issue #211)

You don't often get email from @.*** Learn why this is importanthttps://aka.ms/LearnAboutSenderIdentification

Looks like you forgot to fill pits and depressions and resolve flats. If I leave them out I get the same picture as you.

Condition DEM

----------------------

Fill pits in DEM

pit_filled_dem = grid.fill_pits(dem)

Fill depressions in DEM

flooded_dem = grid.fill_depressions(pit_filled_dem)

Resolve flats in DEM

inflated_dem = grid.resolve_flats(flooded_dem)

— Reply to this email directly, view it on GitHubhttps://github.com/mdbartos/pysheds/issues/211#issuecomment-1424574629, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ALLVP4BOIQ5ZSPFDR4FRHZLWWUT63ANCNFSM6AAAAAAUATPNTE. You are receiving this because you authored the thread.Message ID: @.***>