Closed philippkraft closed 1 year ago
Looks like CI tests are not yet passing.
Ok, I found the reason for this:
The pgrid.to_raster and sgrid.to_raster interfaces are not equal. I have removed my changes to pgrid, should work now.
I will update the CI to include newer versions of Python.
Hi @philippkraft, sorry for the delay. I am getting ready to pull this in. I updated github actions to remove Python 3.6 and run Python 3.10:
It's not running the test for Python 3.10 in this PR. Would it be possible to modify this line on your branch so that it will run the test for Python 3.10?
Thanks, MDB
Hi, I updated my PR's. Feel free to test again.
Great. Could you add a quick unit test of the new functionality to test_grid.py?
https://github.com/mdbartos/pysheds/blob/master/tests/test_grid.py
Added a test with using compress as a keyword
Looks good to me. Will merge now.
Pull request to fix #213. Test is runnning and it works as expected: