mdbartos / pysheds

:earth_americas: Simple and fast watershed delineation in python.
GNU General Public License v3.0
720 stars 196 forks source link

AttributeError when trying to import DEM #215

Open dbaldig opened 1 year ago

dbaldig commented 1 year ago

Hey there,

importing a DEM causes the following error:

import pysheds
from pysheds.grid import Grid

grid = Grid.from_raster("C:/Users/...DEM.tif", data_name='dem')

AttributeError: module 'numpy' has no attribute 'bool'. np.bool was a deprecated alias for the builtin bool. To avoid this error in existing code, use bool by itself. Doing this will not modify any behavior and is safe. If you specifically wanted the numpy scalar type, use np.bool_ here. The aliases was originally deprecated in NumPy 1.20; for more details and guidance see the original release note at: https://numpy.org/devdocs/release/1.20.0-notes.html#deprecations

Seems like you should replace line 159 and 620 in the pgrid.py source file

mdbartos commented 1 year ago

Greetings, I think this is addressed in #212. However, from that conversation it seems that the main issue was that numba is not importing, which prevents sgrid.py from importing. pgrid.py is deprecated in favor of sgrid.py, so the better solution is to fix the numba install.