search

mdbassit / Coloris

A lightweight and elegant JavaScript color picker. Written in vanilla ES6, no dependencies. Accessible.
https://coloris.js.org/examples.html
MIT License
443 stars 58 forks source link

I would like to contribute sass/scss to the repository #132

Closed MattOpen closed 7 months ago

MattOpen commented 7 months ago

Dear @mdbassit,

I have rewritten the CSS part and transformed it into scss. Actually I have only rewritten without any changes to the style and also not created variables. But I could do it later. How can I participate on the project?

cheers Richard

mdbassit commented 7 months ago

Hello Richard,

I intentionally avoided using a CSS pre-compiler cause I need this to work on modern browsers without any building steps. But I thank you for your offer to contribute.

MattOpen commented 7 months ago

Dear Momo,

I don´t understand your point here. The result is the same. After my change, the distribution folder contains the pre compiled Coloris.css file (as of before). image

it is done by the task function watchFiles() { watch(path.js, minifyJS); watch(path.scss, parallel(transpileSCSS)); watch(path.css, parallel(minifyCSS)); }

mdbassit commented 7 months ago

I meant that today, I can include the source J's and css files to a page and they would work out of the box without any build step.

MattOpen commented 7 months ago

Dear Momo, I got it. Then I will create a new fork and do the changes then. Thank you :)

PS: then we can close this issue