search

mdbergmann / cl-tbnl-gserver-tmgr

Hunchentoot Gserver based taskmanager
22 stars 1 forks source link

An error in taskmaster-thread-count method #2

Open svetlyak40wt opened 4 weeks ago

svetlyak40wt commented 4 weeks ago

I've readed a code and found a suspicious code:

(defmethod taskmaster-thread-count :around ((self gserver-tmgr))
  (length (slot-value self 'max-thread-count)))

The problem is that max-thread-count slot has INTEGER type and LENGTH will fail on integer value.

Probably here a length of actors inside a router should be used?

mdbergmann commented 4 weeks ago

Yeah, that's a bug. Should be just (slot-value self 'max-thread-count) I suppose (didn't look up the code). The Sento Router contains 'max-thread-count actors, so could be used directly (I think).