Closed guysmoilov closed 4 years ago
@guysmoilov This PR is now obsolete.
@sodul Not completely sure I understand the difference but ¯_(ツ)_/¯
@sodul Not completely sure I understand the difference but ¯(ツ)/¯
Yes, @guysmoilov, that's pretty much your code but a little more explicit with comments. Our version was from @deepans-clumio, I was just passing along our custom version.
Thank you for making the original fix as it solved a real issue we were facing.
Thanks, that credit goes to @Unmoon though. I just opened the PR with their code fix.
@guysmoilov @Unmoon Thank you for discovering the root case of the issue. and putting out a PR. I just changed the comparator to be more explicit and added some comments. Appreciate your help!
Fixes #9